| meven | |
| ngraham | |
| broulik |
| Plasma |
With the X-Plasma-Request-Actions-Once property the plugin
can specify if the actions should only be requested when the plugin is initialized.
This is useful if the plugin always used the same actions, because
then the we don't need to make the dbus calls for every match session.
Create dbus runner and don't set the extra property, the actions should be requested for each session.
(More like each query because of BUG: 420311).
After setting the property to true the actions should only be requested when the runner is initialized.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Seems good to me.
Before merging, maybe you could make a diff with a few runners in plasma-workspace use it.
And if you could add a test.
| autotests/dbusrunnertest.cpp | ||
|---|---|---|
| 206 | The concept behind this test is, that the runner is just loaded. If the Request-Actions-Once property is correctly implemented the actions are requested when the plugin is initialized. That means that they should be available and prepare doesn't need to be called. So it would make sense to add a signal spy to check if prepare was not called at all, or am I missing something? | |
| autotests/dbusrunnertest.cpp | ||
|---|---|---|
| 206 | I am not sure the test illustrates the change. Only by adding signals spies can you test the actual behavior here. I would trigger a second match and check requestActions was only called once, but prepare called each time as usual. | |