| ngraham | |
| elvisangelaccio |
| Dolphin |
Allow Panel to reuse Dolphin main Context menu.
Move a lot of actions handling from DolphinMainWindow and DolphinView to DolphinViewActionHandler.
In the process expose more slots and accessors.
Pass the KItemListSelectionManager and KFileItemListView of the foldersPanel around to have the selection accessible in DolphinMainWindow and DolphinViewActionHandler.
BUG: 270360
BUG: 406028
BUG: 420587
BUG: 295575
FIXED-IN: 20.08
Using the context menu in the folder panel :
Cuto/copy/paste to and from the folders panel
Duplicate
Rename
Add to places
Move to trash
Delete
Properties
Same using shortcuts (caution giving the foldersPanel the keyboard focus is tricky)
| No Linters Available |
| No Unit Test Coverage |
| Buildable 25915 | |
| Build 25933: arc lint + arc unit |
Hmm, does this patch close the door on that? This seems sensible enough to me at first glance.
Haven't checked but pretty sure we have a context menu signal and/or could add one to KFilePlacesView similar to how we made the terminal teardown stuff work.
Make DolphinViewActionHandler the main executors for most actions, allow it to have set the selectionManager and itemlistViem to operate on
Sorry for the delay in reviewing. This is a large and somewhat intimidating patch :) I will check it out soon.
I can move it to gitlab if it eases review.
I hope my commit message helps a little.
This has some merge conflicts if I try to rebase it on current master Can you rebase it?
It will need quite some work to rebase indded, since this introduce the concept of having context menu actions in DolphinViewActionHandler and this is now a few weeks old...
I might rename DolphinViewActionHandler to simply DolphinActionHandler since this will be more relevant.
I believe the code will overall be in better shape that previous with more code delegated to DolphinViewActionHandler rather that bloating forever DolphinView and DolphinMainWindow.
Might move to gitlab directly as this is just in the infancy of the review.