Differential D29126

KNewStuff: port from KRun::runApplication to KIO::ApplicationLauncherJob
ClosedPublic
Actions

Authored by dfaure on Apr 23 2020, 9:59 AM.

Details

Reviewers
ngraham
broulik
leinir
Commits
R304:6120a1298293: KNewStuff: port from KRun::runApplication to KIO::ApplicationLauncherJob
Summary

The plan is to deprecate KRun::run*

Test Plan

Builds

Diff Detail

Repository
R304 KNewStuff
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25745
Build 25763: arc lint + arc unit
dfaure created this revision.Apr 23 2020, 9:59 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 23 2020, 9:59 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
dfaure requested review of this revision.Apr 23 2020, 9:59 AM
leinir accepted this revision.Apr 23 2020, 10:38 AM
leinir added a subscriber: leinir.

Was /just/ about to be all "nooo, widgets in core, crying forever" but this isn't core, so go for it ;)

This revision is now accepted and ready to land.Apr 23 2020, 10:38 AM
dfaure added a comment.Apr 23 2020, 10:41 AM

And KRun was widgets based too. At least now you can get rid of widgets completely (for this bit about starting apps) by connecting to the result() signal yourself instead of using a dialog ui delegate. There's also a knotifications based ui delegate, but not sure it's appropriate here (that's more for plasma itself I would say).

dfaure closed this revision.Apr 23 2020, 10:41 AM
leinir added a comment.Apr 23 2020, 10:42 AM
In D29126#655523, @dfaure wrote:

And KRun was widgets based too. At least now you can get rid of widgets completely (for this bit about starting apps) by connecting to the result() signal yourself instead of using a dialog ui delegate. There's also a knotifications based ui delegate, but not sure it's appropriate here (that's more for plasma itself I would say).

Indeed! 'tis all very handy - and thanks :)

Revision Contents
Changeset List

Diff 80974

View Options

src/kmoretools/kmoretoolsmenufactory.cpp

Loading...