[Wayland] Add to PlasmaWindowManagement protocol windows stacking order
ClosedPublic

Authored by bport on Apr 21 2020, 2:54 PM.

Diff Detail

Repository
R127 KWayland
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 25618
Build 25636: arc lint + arc unit
bport created this revision.Apr 21 2020, 2:54 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 21 2020, 2:54 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bport requested review of this revision.Apr 21 2020, 2:54 PM
davidedmundson added inline comments.Apr 21 2020, 3:20 PM
src/client/protocols/plasma-window-management.xml
77 ↗(On Diff #80772)

we also need to send it on bind

83 ↗(On Diff #80772)

Can we change them all at once.

src/server/plasmawindowmanagement_interface.cpp
167 ↗(On Diff #80772)

This needs a

wl_resource_get_version(resource) < ORG_KDE_PLASMA_SEND_STACK_SOMETHING_SOMETHING_SINCE_VERSION

A user could be using a flatpak or something with a bundled kwayland that's out of date with kwin. At that point we don't want the client to receive this event or it will explode.

234 ↗(On Diff #80772)

We need to send the stacking order here, this way if a client connects and nothing changes, they still have the right order.

bport updated this revision to Diff 80784.Apr 21 2020, 4:27 PM
bport marked 4 inline comments as done.
  • Send stack order on bind
  • Check ressource have good protocol version
zzag added inline comments.Apr 22 2020, 6:13 AM
src/client/plasmawindowmanagement.cpp
242

The opening brace must be on a new line.

251

Should be a const ref.

bport updated this revision to Diff 80887.Apr 22 2020, 1:57 PM

Increase protocol version and use const ref for QVector parameter

zzag added inline comments.Apr 22 2020, 2:01 PM
src/client/plasmawindowmanagement.cpp
47 ↗(On Diff #80772)

Coding style: whitespace before & and *

src/server/plasmawindowmanagement_interface.cpp
293 ↗(On Diff #80772)

const ref

bport updated this revision to Diff 80901.Apr 22 2020, 3:10 PM

Add missing const ref and fix coding style

davidedmundson accepted this revision.Apr 22 2020, 3:31 PM
This revision is now accepted and ready to land.Apr 22 2020, 3:31 PM
zzag added inline comments.Apr 23 2020, 5:11 AM
src/server/plasmawindowmanagement_interface.cpp
293 ↗(On Diff #80772)

coding style: whitespace before &

meven added a subscriber: meven.Apr 24 2020, 12:54 PM
meven added inline comments.
src/server/plasmawindowmanagement_interface.h
76 ↗(On Diff #80772)

A space too many

zzag added inline comments.Apr 24 2020, 1:56 PM
src/client/protocols/plasma-window-management.xml
74 ↗(On Diff #80772)

To be in-line with upstream standards, please add <!-- Version 11 additions -->.

This revision was automatically updated to reflect the committed changes.