Differential D29002

Information Panel: Make icons as big as previews
ClosedPublic
Actions

Authored by meven on Apr 20 2020, 6:35 AM.

Details

Reviewers
ngraham
elvisangelaccio
Group Reviewers
Dolphin
Commits
R318:cb085066ae1c: Information Panel: Make icons as big as previews
Summary

Make icons match the preview size.
It prevents a user that had a wide information panel,
seeing a size difference between a preview and an icon despite they can look similar (i.e folder preview).

Test Plan

Before:

After:

Diff Detail

Repository
R318 Dolphin
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25494
Build 25512: arc lint + arc unit
meven created this revision.Apr 20 2020, 6:35 AM
Restricted Application added a project: Dolphin. · View Herald TranscriptApr 20 2020, 6:35 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
meven requested review of this revision.Apr 20 2020, 6:35 AM
meven edited the test plan for this revision. (Show Details)Apr 20 2020, 6:37 AM
meven added a reviewer: elvisangelaccio.

Split of D26901.

ngraham accepted this revision.Apr 20 2020, 5:36 PM
This revision is now accepted and ready to land.Apr 20 2020, 5:36 PM
elvisangelaccio accepted this revision.Apr 20 2020, 10:49 PM

Still not a fan of the huge icon, but ok :)

Closed by commit R318:cb085066ae1c: Information Panel: Make icons as big as previews (authored by meven). · Explain WhyApr 21 2020, 7:20 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 80609

View Options

src/panels/information/informationpanelcontent.cpp

Loading...