Differential D28822

Create StreamRestore channel if none exists
ClosedPublic
Actions

Authored by nicolasfella on Apr 14 2020, 1:46 PM.

Details

Reviewers
drosca
broulik
ngraham
Group Reviewers
Plasma
Commits
R115:5bdd13689579: Create StreamRestore channel if none exists
R115:aea2f25dd225: Merge branch 'Plasma/5.18'
Summary

We need one channel to be able to control the volume. This restores D7485 which was broken by D20450 while fixing a different issue.
This patch tries to combine the two by only creating a new channel if none exists and not messing with existing ones.

BUG: 407397

Test Plan

Can control the notification volume in the KCM now. The slider position matches the one in pavucontrol

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Apr 14 2020, 1:46 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 14 2020, 1:46 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Apr 14 2020, 1:46 PM
nicolasfella edited the summary of this revision. (Show Details)Apr 14 2020, 1:46 PM
ngraham accepted this revision.Apr 14 2020, 3:05 PM
ngraham added a subscriber: ngraham.

OMG you fixed it! Works for me.

Would be great to get this into the stable branch.

This revision is now accepted and ready to land.Apr 14 2020, 3:05 PM
Closed by commit R115:5bdd13689579: Create StreamRestore channel if none exists (authored by nicolasfella). · Explain WhyApr 15 2020, 11:22 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/streamrestore.cpp (14 lines)

Diff 80189

View Options

src/streamrestore.cpp

Loading...