Differential D20450

[StreamRestore] Don't mess with channels
ClosedPublic
Actions

Authored by broulik on Apr 10 2019, 8:40 PM.

Details

Reviewers
drosca
nicolasfella
Group Reviewers
Plasma
Commits
R115:fbdef07f554b: [StreamRestore] Don't mess with channels
Summary

Just set volume for all of them.
Otherwise when just calling setMuted, we will send the original volume struct, which might have multiple channels,
with a hardcoded channel map that only has one channel. PulseAudio then refuses to write the settings.

Patch ported from pulseaudio-qt

BUG: 398392
FIXED-IN: 5.15.5

Test Plan

None. Compiled.

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 10 2019, 8:40 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 10 2019, 8:40 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 10 2019, 8:40 PM
broulik edited the summary of this revision. (Show Details)Apr 10 2019, 8:42 PM
drosca accepted this revision.Apr 11 2019, 6:08 AM
This revision is now accepted and ready to land.Apr 11 2019, 6:08 AM
Closed by commit R115:fbdef07f554b: [StreamRestore] Don't mess with channels (authored by broulik). · Explain WhyApr 11 2019, 7:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/streamrestore.cpp (8 lines)

Diff 55971

View Options

src/streamrestore.cpp

Loading...