Differential D28801

Dolphin Service Menu installer cleanup
ClosedPublic
Actions

Authored by alex on Apr 13 2020, 5:35 PM.

Details

Reviewers
ngraham
nicolasfella
elvisangelaccio
Group Reviewers
Dolphin
Commits
R318:76f9d9a5f5c6: Dolphin Service Menu installer cleanup
Summary

This patch contains some smaller formatting/coding style changes
to avoid unrelated changes in other patches.

  • Use {} instead of QStringList{} consistently
  • Use parehthesese in UncompressCommand({}) consistently
  • Use QStringList name = {} instead of auto name = QStringList{}
  • Add one qAsConst, remove qAsConst if value is already const
Test Plan

Compile, install and run tests

Diff Detail

Repository
R318 Dolphin
Branch
servicemenuinstaller_cleanup (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25175
Build 25193: arc lint + arc unit
alex created this revision.Apr 13 2020, 5:35 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptApr 13 2020, 5:35 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
alex requested review of this revision.Apr 13 2020, 5:35 PM
elvisangelaccio accepted this revision.Apr 13 2020, 5:54 PM
elvisangelaccio added a subscriber: elvisangelaccio.
elvisangelaccio added inline comments.
src/settings/services/servicemenuinstaller/servicemenuinstaller.cpp
278 ↗(On Diff #80037)

While at it, make it const.

This revision is now accepted and ready to land.Apr 13 2020, 5:54 PM
alex updated this revision to Diff 80038.Apr 13 2020, 5:58 PM

Add const modifiers

ngraham accepted this revision.Apr 13 2020, 6:43 PM

I was just about to say the same thing. :)

alex added a comment.Apr 13 2020, 7:13 PM

Quick question: Should I also push this to release/20.04?
Because there are some broken plugin in the KDE store (install and uninstall scripts)
and this patch is like a preparation patch to fix this.

elvisangelaccio added a comment.Apr 14 2020, 10:13 PM
In D28801#647488, @alex wrote:

Quick question: Should I also push this to release/20.04?
Because there are some broken plugin in the KDE store (install and uninstall scripts)
and this patch is like a preparation patch to fix this.

Yes please.

Closed by commit R318:76f9d9a5f5c6: Dolphin Service Menu installer cleanup (authored by alex). · Explain WhyApr 17 2020, 1:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 80038

View Options

src/settings/services/servicemenuinstaller/servicemenuinstaller.cpp

Loading...