When you are inside the services store and you choose to install a deb/rpm package
they open in the default application (most likely a package installer utility like discover).
Details
Details
- Reviewers
elvisangelaccio ngraham aspotashev - Group Reviewers
Dolphin - Commits
- R318:514d9c8fc970: Dolphin Services: Launch Deb/Rpm archives with QDesktopServices
Tests still pass, try out what was described in the summary.
A product which has a deb/rpm package is for example: Jetbrains Dolphin Plugin
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Branch
- dolphin_service_menu_deb_rpm (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 25162 Build 25180: arc lint + arc unit
| src/settings/services/servicemenuinstaller/servicemenuinstaller.cpp | ||
|---|---|---|
| 39 ↗ | (On Diff #80015) | unrelated to this patch; don't change it here regardless |
| 90 ↗ | (On Diff #80015) | unrelated to this patch; don't change it here regardless |
| 279 ↗ | (On Diff #80015) | unrelated to this patch; don't change it here regardless |
| 331 ↗ | (On Diff #80015) | Why change this? |
| src/settings/services/servicemenuinstaller/servicemenuinstaller.cpp | ||
|---|---|---|
| 331 ↗ | (On Diff #80015) | Otherwise the QDesktopServices can't be used |
Comment Actions
And regarding the todos I added: I just wanted to get some feedback on the ideas before creating a patch for them.
Or should I create a task, even for smaller issues/ideas like this?
Comment Actions
Yeah, open a phab task, or even better, just open a new patch for the proposed changes and have the discussion there. :)
Adding TODO comments into this unrelated patch is just an additional barrier to merging though, as you need to remove them before we can land it.
Comment Actions
Thanks!
| src/settings/services/servicemenuinstaller/servicemenuinstaller.cpp | ||
|---|---|---|
| 207 | Theoretically people could put .appimage or .flatpakref files in here too, right? Maybe we should handle those too. | |
| src/settings/services/servicemenuinstaller/servicemenuinstaller.cpp | ||
|---|---|---|
| 207 | What would be the usecase for this? | |
| src/settings/services/servicemenuinstaller/servicemenuinstaller.cpp | ||
|---|---|---|
| 29 | Drop the QtGui/ prefix | |
| src/settings/services/servicemenuinstaller/servicemenuinstaller.cpp | ||
|---|---|---|
| 207 | Ah, of course. | |
| src/settings/services/servicemenuinstaller/CMakeLists.txt | ||
|---|---|---|
| 7 ↗ | (On Diff #80015) | Why Widgets? Qt5::Gui should be enough |