When you are inside the services store and you choose to install a deb/rpm package
they open in the default application (most likely a package installer utility like discover).
Details
- Reviewers
elvisangelaccio ngraham aspotashev - Group Reviewers
Dolphin - Commits
- R318:514d9c8fc970: Dolphin Services: Launch Deb/Rpm archives with QDesktopServices
Tests still pass, try out what was described in the summary.
A product which has a deb/rpm package is for example: Jetbrains Dolphin Plugin
Diff Detail
- Repository
- R318 Dolphin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
src/settings/services/servicemenuinstaller/servicemenuinstaller.cpp | ||
---|---|---|
328 | Otherwise the QDesktopServices can't be used |
And regarding the todos I added: I just wanted to get some feedback on the ideas before creating a patch for them.
Or should I create a task, even for smaller issues/ideas like this?
Yeah, open a phab task, or even better, just open a new patch for the proposed changes and have the discussion there. :)
Adding TODO comments into this unrelated patch is just an additional barrier to merging though, as you need to remove them before we can land it.
Thanks!
src/settings/services/servicemenuinstaller/servicemenuinstaller.cpp | ||
---|---|---|
207 | Theoretically people could put .appimage or .flatpakref files in here too, right? Maybe we should handle those too. |
src/settings/services/servicemenuinstaller/servicemenuinstaller.cpp | ||
---|---|---|
207 | What would be the usecase for this? |
src/settings/services/servicemenuinstaller/servicemenuinstaller.cpp | ||
---|---|---|
29 | Drop the QtGui/ prefix |
src/settings/services/servicemenuinstaller/servicemenuinstaller.cpp | ||
---|---|---|
207 | Ah, of course. |
src/settings/services/servicemenuinstaller/CMakeLists.txt | ||
---|---|---|
7 | Why Widgets? Qt5::Gui should be enough |