Differential D28656

KCM LookAndFeel check if splash screen is provided before applying it.
ClosedPublic
Actions

Authored by crossi on Apr 7 2020, 1:54 PM.

Details

Reviewers
ervin
bport
meven
ngraham
Group Reviewers
Plasma
Commits
R119:dacb3a8bdd20: KCM LookAndFeel check if splash screen is provided before applying it.
Summary

BUG: 414417

  • While saving a new global theme, don't set splash screen if none is provided, leave the current one.
  • KSplash kcfg set default to breeze instead of the current lnf theme which may not contain a splash screen.
Test Plan
  • Open LookAndFeel KCM, apply Breeze Dark, then open Splash screen KCM, Breeze should be highlighted.
  • Open splash screen KCM, select none, click on defaults, Breeze should be selected.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 24903
Build 24921: arc lint + arc unit
crossi created this revision.Apr 7 2020, 1:54 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 7 2020, 1:55 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
crossi requested review of this revision.Apr 7 2020, 1:55 PM
ervin accepted this revision.Apr 7 2020, 2:40 PM
This revision is now accepted and ready to land.Apr 7 2020, 2:40 PM
ngraham accepted this revision.Apr 14 2020, 2:55 PM
ngraham added a subscriber: ngraham.

LGTM. Stable branch-worthy, probably.

Closed by commit R119:dacb3a8bdd20: KCM LookAndFeel check if splash screen is provided before applying it. (authored by crossi). · Explain WhyApr 22 2020, 2:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 79574

View Options

kcms/ksplash/splashscreensettings.kcfg

Loading...
View Options

kcms/lookandfeel/kcm.cpp

Loading...