KCM LookAndFeel check if splash screen is provided before applying it.
ClosedPublic
Actions

Authored by crossi on Apr 7 2020, 1:54 PM.

Details

Reviewers

Group Reviewers

Plasma

Commits

Summary

BUG: 414417

While saving a new global theme, don't set splash screen if none is provided, leave the current one.
KSplash kcfg set default to breeze instead of the current lnf theme which may not contain a splash screen.

Test Plan

Open LookAndFeel KCM, apply Breeze Dark, then open Splash screen KCM, Breeze should be highlighted.
Open splash screen KCM, select none, click on defaults, Breeze should be selected.

Repository

R119 Plasma Desktop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

crossi requested review of this revision.Apr 7 2020, 1:55 PM

This revision is now accepted and ready to land.Apr 7 2020, 2:40 PM

LGTM. Stable branch-worthy, probably.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			kcms/ksplash/splashscreensettings.kcfg (5 lines)
M			kcms/lookandfeel/kcm.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	79574	77cda8d		Apr 7 2020, 1:54 PM	★	★
Diff 2	80896	17ef374	R119:dacb3a8bdd206ec14a588bb25b37caa48c3b36aa	Apr 22 2020, 2:43 PM	★	★