Details
- Reviewers
bruns broulik - Group Reviewers
Plasma - Commits
- R120:768e6a0a229d: BookmarksRunner: Remove caching of profile database path
Should compile, no changes to lookup logic made.
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
There are two possible ways of changing the caching, and each one will break behavior for one of two different groups of users:
- People who rely on the krunner following the default profile.
- People who rely on krunner using the dbfile config entry.
I would argue for just removing the grp.writeEntry("dbfile", m_dbFile) line. This keeps the current behavior for the second group, and still solves the problem for the first group when there is no config yet. Only users of the second group with an existing config have to do a one-time change to their config, e.g. resetting/removing the "dbfile" config value.
I would argue for just removing the grp.writeEntry("dbfile", m_dbFile) line. This keeps the current behavior for the second group, and still solves the problem for the first group when there is no config yet. Only users of the second group with an existing config have to do a one-time change to their config, e.g. resetting/removing the "dbfile" config value.
But what about renaming the dbfile entry, maybe to alternate_dbfile ? Then the second group of users has to adapt to the changes and
the first group can be sure that the default profile gets looked up correctly (in case the config already exists).
Edit: I initially thought that removing this is the best Idea, because this feature causes issues and is not documented (other that in the source code). And I don't see an actual usecase to load the bookmarks from another profile and launch them in the default one.
Please just remove the writeEntry.
You can then propose "But what about renaming the dbfile entry, maybe to alternate_dbfile?" as another review.