As requested in D28196 this patch handles the early return and the formatting.
Additionally QRegularExpression has been used instead of QRegExp and QStringLiteral instead of QString.
Details
Details
- Reviewers
bruns broulik - Group Reviewers
Plasma - Commits
- R120:e518d45a4d61: BookmarksRunner: Early return and formatting
Should compile and work exactly as before.
To test migration to QRegularExpression:
create multiple profiles
delete the dbfile entry from the general group in .config/kdeglobals
restart krunner and make sure that the value of the dbfile entry is the path to the default profile.
The bookmarks should also be displayed.
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Should compile and work exactly as before.
Please always test QRegularExpression migration, I've seen just too many regressions when this wasn't done carefully
| runners/bookmarks/browsers/firefox.cpp | ||
|---|---|---|
| 170 | The default argument is sufficient to resolve the type, readEntry("foo", QString()) is enough | |
Comment Actions
Implement requested changes.
PS: I had already tested the migration locally and added it to the test plan.
| runners/bookmarks/browsers/firefox.cpp | ||
|---|---|---|
| 199 | Can you leave this in, and even promote it to an active qWarning* - if we have a db and profiles file, but can't determine the default profile, something is definitely wrong.
| |
| 215 | This can IMHO also be promoted to an active warning. | |
| runners/bookmarks/browsers/firefox.cpp | ||
|---|---|---|
| 165 | Thanks, though I was wrong about "no categories yet". #include "bookmarks_debug" ... qCWarning(RUNNER_BOOKMARKS) << ... | |
Comment Actions
Should this(and the following patches) go to a stable branch, because they fix a bug that has been reported (418526)?