BUGFIX BookmarksRunner: Fix wrong default profile extraction, remove caching
Needs ReviewPublic

Authored by alex on Sun, Mar 22, 7:37 AM.

Details

Reviewers
bruns
z3ntu
apol
broulik
davidedmundson
Group Reviewers
Plasma
Summary

Before this patch the path to the default profile database was once read and then written in the config. And as long as this file exists this value would be used. But if the user changes the default profile in Firefox the old profile will still be used (as long as it is not deleted).

And the default profile was also not always correctly extracted (this configuration got only edited in the about:profiles page in Firefox):

Test Plan

Test if the bookmarks are correctly displayed (with a single profile), add a new profile and restart KRunner, set the default profile back to the old profile and restart KRunner.
The bookmarks should always be displayed.

Diff Detail

Repository
R120 Plasma Workspace
Branch
bookmarks_firefox_bugfix (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24054
Build 24072: arc lint + arc unit
alex created this revision.Sun, Mar 22, 7:37 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSun, Mar 22, 7:37 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
alex requested review of this revision.Sun, Mar 22, 7:37 AM
alex added a reviewer: Plasma.Sun, Mar 22, 7:38 AM
alex updated this revision to Diff 78205.Sun, Mar 22, 9:05 AM

Add check if profilePath is empty