Before this patch the path to the default profile database was once read and then written in the config. And as long as this file exists this value would be used. But if the user changes the default profile in Firefox the old profile will still be used (as long as it is not deleted).
And the default profile was also not always correctly extracted (this configuration got only edited in the about:profiles page in Firefox):
Test if the bookmarks are correctly displayed (with a single profile), add a new profile and restart KRunner, set the default profile back to the old profile and restart KRunner.
The bookmarks should always be displayed.
| No Linters Available |
| No Unit Test Coverage |
| Buildable 24054 | |
| Build 24072: arc lint + arc unit |
Can you split out the early-return part for the QSQLite driver and submit it as a preparation patch?
It adds quite some noise to the diff due to the whitespace changes (though I fully agree it is the better coding pattern).
Regarding the summary:
This should be 3 submission: