Apply the correct palette to icons
ClosedPublic

Authored by davidre on Mar 30 2020, 1:04 PM.

Details

Summary

Our icons can be recolored. However there is a difference between custom colors
on widgets and icons. We will respect the palette but KIconLoader that creates
the icon pixmaps operates on an application wide palette basis. This can create
miscolored icons when a widget has a custom palette. A helper function is
introduced to load the pixmaps that switches the palette of the global
KIconLoader if necessary and resets it appropriately.

Test Plan

Before:


After:

Diff Detail

Repository
R31 Breeze
Branch
iconspalette (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24465
Build 24483: arc lint + arc unit
davidre created this revision.Mar 30 2020, 1:04 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 30 2020, 1:04 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidre requested review of this revision.Mar 30 2020, 1:04 PM
davidre edited the test plan for this revision. (Show Details)Mar 30 2020, 1:05 PM
davidre added a reviewer: Breeze.
cblack accepted this revision.Apr 1 2020, 4:19 PM
This revision is now accepted and ready to land.Apr 1 2020, 4:19 PM
mart accepted this revision.Apr 6 2020, 10:02 AM
This revision was automatically updated to reflect the committed changes.