Differential D28349

Fix Warnings
ClosedPublic
Actions

Authored by meven on Mar 27 2020, 2:28 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Frameworks
Commits
R244:fcdf263339b4: Fix Warnings
Summary

We had 10 compile warnings before.
0 after

Diff Detail

Repository
R244 KCoreAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Mar 27 2020, 2:28 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 27 2020, 2:28 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Mar 27 2020, 2:28 PM
davidedmundson added a subscriber: davidedmundson.Mar 27 2020, 2:31 PM
davidedmundson added inline comments.
autotests/kprocesstest_helper.cpp
17

If we use argv[1] we very much should be using argc beforehand

meven updated this revision to Diff 78655.Mar 27 2020, 2:39 PM

Add an argc value check

davidedmundson accepted this revision.Mar 27 2020, 2:44 PM
This revision is now accepted and ready to land.Mar 27 2020, 2:44 PM
Closed by commit R244:fcdf263339b4: Fix Warnings (authored by meven). · Explain WhyMar 27 2020, 2:45 PM
This revision was automatically updated to reflect the committed changes.
iasensio added a subscriber: iasensio.Mar 30 2020, 8:29 PM

I seemed to reach the unreachable when I tried to open an external HDD on dolphin:
https://bugs.kde.org/show_bug.cgi?id=419428

ASSERT failure in Q_UNREACHABLE(): "Q_UNREACHABLE was reached", file /home/isma/kde/src/kcoreaddons/src/lib/io/kdirwatch.cpp, line 956

bruns added a subscriber: bruns.Mar 30 2020, 9:02 PM

@iasensio - are you using NFS?

src/lib/io/kdirwatch.cpp
946

m_nfsPreferredMethod defaults to KDirWatch::FAM, i.e. it will crash below now on NFS when FAM is disabled.

meven added inline comments.Mar 31 2020, 7:46 AM
src/lib/io/kdirwatch.cpp
946

So either change the default, or add a Q_FALLTHROUH() ?

iasensio added a comment.Mar 31 2020, 9:07 AM
In D28349#638395, @bruns wrote:

@iasensio - are you using NFS?

It's a NTFS partition using fuseblk, but anyway D28457 fixes the crash

Revision Contents
Changeset List

Diff 78656

View Options

autotests/kprocesstest_helper.cpp

Loading...
View Options

src/lib/caching/kshareddatacache.cpp

Loading...
View Options

src/lib/io/kdirwatch.cpp

Loading...