Bug 419174 Translation german spelling issues
ClosedPublic

Authored by sreschke on Tue, Mar 24, 9:26 AM.

Details

Summary
  • Fix: german spelling issues
  • Chg: plural to singular
  • Add: missing word from english words
Test Plan
  • none

Diff Detail

Repository
R2 GCompris
Branch
shared/topic/translation_german_spellingissues (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24135
Build 24153: arc lint + arc unit
sreschke created this revision.Tue, Mar 24, 9:26 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptTue, Mar 24, 9:26 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
sreschke requested review of this revision.Tue, Mar 24, 9:26 AM

There are some German translations that use the female word but others use the male one.
e.g. soldier vs der Soldat vs die Soldatin

src/activities/lang/resource/content-de.json
867

die Soldatin

jjazeix added a subscriber: jjazeix.
schwarzer accepted this revision.Wed, Mar 25, 8:28 AM
schwarzer added a subscriber: schwarzer.

I cannot say anything about the soldier since I do not know how this is presented in the application. The rest looks good, thanks.

This revision is now accepted and ready to land.Wed, Mar 25, 8:28 AM

I cannot say anything about the soldier since I do not know how this is presented in the application. The rest looks good, thanks.

GCompris soldier.png:

https://github.com/gcompris/GCompris-data/blob/master/words/words/soldier.png

I cannot say anything about the soldier since I do not know how this is presented in the application. The rest looks good, thanks.

GCompris soldier.png:

https://github.com/gcompris/GCompris-data/blob/master/words/words/soldier.png

Thanks!

@sreschke Can you please change the gender then? :)

jjazeix closed this revision.Wed, Mar 25, 8:54 AM

Thank you all,
I updated the soldier to: "der Soldat"
I commited it on https://phabricator.kde.org/R883:1565122 (the po generates the json file).