Differential D28114

Add call-incoming/missed/outgoing
ClosedPublic
Actions

Authored by ndavis on Mar 18 2020, 6:26 AM.

Details

Reviewers
cblack
Group Reviewers
VDG
Commits
R266:3e095e86bfae: Add call-incoming/missed/outgoing
Summary

Requested by @bshah for Plasma Mobile

Test Plan

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Mar 18 2020, 6:26 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 18 2020, 6:26 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.Mar 18 2020, 6:26 AM
ndavis edited the summary of this revision. (Show Details)Mar 18 2020, 6:28 AM
ndavis edited the test plan for this revision. (Show Details)
ndavis added a subscriber: bshah.
bshah awarded a token.Mar 18 2020, 7:24 AM
bshah added a subscriber: jbbgameich.
cblack requested changes to this revision.Mar 18 2020, 7:50 AM
cblack added a subscriber: cblack.

The 16px icons should probably drop the phone, as the distinguishing elements between them are so small as to impair the ease of telling the icons apart. Legibility should be prioritised over metaphor.

This revision now requires changes to proceed.Mar 18 2020, 7:50 AM
ndavis updated this revision to Diff 77889.EditedMar 18 2020, 9:43 AM
  • Move to status category
  • Make phone size smaller and more consistent at 16px
ndavis edited the test plan for this revision. (Show Details)Mar 18 2020, 9:45 AM
broulik added a subscriber: broulik.Mar 18 2020, 9:45 AM

Leave the phone in, please. I'm having a hard time grasping the pure arrow icons Android uses in the dialer.

ndavis added a comment.Mar 18 2020, 9:46 AM
In D28114#629728, @broulik wrote:

Leave the phone in, please. I'm having a hard time grasping the pure arrow icons Android uses in the dialer.

I knew I couldn't be the only one :)

This revision was not accepted when it landed; it landed in state Needs Review.Mar 18 2020, 11:45 AM
Closed by commit R266:3e095e86bfae: Add call-incoming/missed/outgoing (authored by ndavis). · Explain Why
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 24 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 77900