[breeze-icons] add TeamViewer tray icons

Authored by rocka on Mar 17 2020, 9:56 AM.



Created TeamViewer tray icons following Breeze style.

Test Plan



Diff Detail

R266 Breeze Icons
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
rocka created this revision.Mar 17 2020, 9:56 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 17 2020, 9:56 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
rocka requested review of this revision.Mar 17 2020, 9:56 AM
rocka edited the test plan for this revision. (Show Details)Mar 17 2020, 9:57 AM
rocka added a reviewer: VDG.
ngraham accepted this revision.Mar 17 2020, 4:26 PM
ngraham added subscribers: ndavis, ngraham.

LGTM. @ndavis?

This revision is now accepted and ready to land.Mar 17 2020, 4:26 PM
ndavis accepted this revision.Mar 17 2020, 5:33 PM
This revision was automatically updated to reflect the committed changes.

I didn't notice it before, but this patch makes TeamViewer's app icon always use the monochrome version now:

We already have a Breeze icon for TeamViewer called teamviewer note the capitalization. It seems like somewhere in our stack, teamviewer and TeamViewer get mixed up such that everything uses the monochrome icon.

rocka added a comment.Mar 19 2020, 1:33 AM

Could we just create a symlink TeamViewer.svg points to 48px teamviewer.svg? And I noticed that in their latest version, they changed the Icon in desktop entry file to TeamViewer, and all the installed icons were named TeamViewer.

After creating that symlink, the icon works fine in Task Manager and Application Dashboard, but still looks monochrome in Application Launcher and Application Menu.

That will help for people using thick panels who see larger icons, but users of thin panels will still get the monochrome icon.

It's yet another example of our inability to deterministically T10413: Find a way to specify whether to use monochrome or color icons in applications. :/

That said, TeamViewer changing the icon means that our current teamviewer icon isn't used at all, so I guess renaming its larger sizes to match the same name as the system tray icon would be better than nothing.

When I updated my parents' PC, they lost the TeamViewer desktop icon because it became monochrome.
Confirmed locally, the TeamViewer icon in the Dashboard menu is also monochrome.
This does not happen to the recently introduced Flameshot icon, so what's the difference here?

Oh gosh, Can confirm. :/

Now we have two icons with different casing: teamviewer (colorful, app icon) and TeamViewer (monochrome, tray icon). I guess the app uses the same icon name for its tray icon as its main icon (boooo) and also KIconLoader isn't case-sensitive (boooo)? Yikes, what a mess. :/ Not sure what we do here TBH

Couldn't we put the tray icon in the plasma theme?