Populate Greeter process exit stderr
ClosedPublic

Authored by romangg on Mar 16 2020, 7:45 PM.

Details

Summary

Give more info in debug output when and how the Greeter porcess exited and
what counter-measures are triggered to unregular exits.

Should simplify debugging.

Diff Detail

Repository
R133 KScreenLocker
Branch
debug
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23777
Build 23795: arc lint + arc unit
romangg created this revision.Mar 16 2020, 7:45 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 16 2020, 7:45 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
romangg requested review of this revision.Mar 16 2020, 7:45 PM
zzag added a subscriber: zzag.Mar 16 2020, 8:26 PM
zzag added inline comments.
ksldapp.cpp
256

Shouldn't it be in an else branch?

romangg added inline comments.Mar 16 2020, 8:32 PM
ksldapp.cpp
256

Yes, thanks!

romangg updated this revision to Diff 77784.Mar 16 2020, 9:49 PM

else case

romangg marked 2 inline comments as done.Mar 16 2020, 9:50 PM
apol accepted this revision.Mar 16 2020, 11:09 PM
This revision is now accepted and ready to land.Mar 16 2020, 11:09 PM

Can we use categorised logging please.

But general +1

Can we use categorised logging please.

Yea, but I haven't seen any categorized logging in KScreenLocker so I opted for now with non-categorized logging as the rest of the code does. The category logging should be introduced for sure in another patch though (and then all debug messages converted to categorized logging at once).

But general +1

This revision was automatically updated to reflect the committed changes.