Differential D27876

KRearrangeColumnsProxyModel: reset in setSourceColumns()
ClosedPublic
Actions

Authored by dfaure on Mar 5 2020, 3:25 PM.

Details

Reviewers
kossebau
vkrause
davidedmundson
ahiemstra
Commits
R275:1af2effd032b: KRearrangeColumnsProxyModel: reset in setSourceColumns()
Summary

Otherwise the view won't update, when doing this dynamically.
With a test program.

Test Plan

See test program

Diff Detail

Repository
R275 KItemModels
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23331
Build 23349: arc lint + arc unit
dfaure created this revision.Mar 5 2020, 3:25 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 5 2020, 3:25 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
dfaure requested review of this revision.Mar 5 2020, 3:25 PM
davidedmundson accepted this revision.Mar 5 2020, 3:31 PM
This revision is now accepted and ready to land.Mar 5 2020, 3:31 PM
kossebau added a comment.Mar 5 2020, 3:32 PM

Small nitpick: can we have initializer lists for the stringlist and columns in the tests, to promote (IMHO) good C++ code? :)

dfaure updated this revision to Diff 77047.Mar 5 2020, 4:31 PM

Use initializer lists

kossebau added inline comments.Mar 5 2020, 4:35 PM
tests/rearrangecolumns.cpp
37

Thanks :) This one slipped?

dfaure added a comment.Mar 5 2020, 5:24 PM

It did indeed... Thanks, fixing.

dfaure closed this revision.Mar 5 2020, 5:24 PM

Revision Contents
Changeset List

Diff 77047

View Options

src/core/krearrangecolumnsproxymodel.cpp

Loading...
View Options

tests/CMakeLists.txt

Loading...
View Options

tests/rearrangecolumns.cpp

Loading...