| davidedmundson |
| Plasma |
This moves Formatter and Unit out of ProcessCore and into its own Formatter library.
This allows us to reuse them in other places, like a new sensor library that will be
posted later.
It includes a declarative plugin that makes things available to QML.
It also contains a small unit test for Formatter.
| No Linters Available |
| No Unit Test Coverage |
| Buildable 23322 | |
| Build 23340: arc lint + arc unit |
| processcore/unit.h | ||
|---|---|---|
| 81 | No Fahrenheit for us poor Americans? :) | |
| processcore/unit.h | ||
|---|---|---|
| 81 | Oops, sorry. | |
cmake fails with:
... -- Configuring done CMake Error at formatter/declarative/CMakeLists.txt:3 (add_library): Target "FormatterPlugin" links to target "Qt5::Qml" but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing?
(Qt 5.14.*)
I guess that top-level CMakeLists.txt needs:
--- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -27,7 +27,7 @@ include(FeatureSummary) include(GenerateExportHeader) -find_package(Qt5 ${QT_MIN_VERSION} REQUIRED CONFIG COMPONENTS DBus Network Widgets) +find_package(Qt5 ${QT_MIN_VERSION} REQUIRED CONFIG COMPONENTS DBus Network Qml Widgets) find_package(Qt5WebEngineWidgets ${QT_MIN_VERSION} CONFIG) set_package_properties(Qt5WebEngineWidgets PROPERTIES URL "git://code.qt.org/qt/qtwebenginewidgets.git"