Differential D27827

Move from Quad to Cubic
ClosedPublic
Actions

Authored by niccolove on Mar 4 2020, 10:53 AM.

Details

Reviewers
ngraham
Group Reviewers
KWin
Commits
R108:f9394d83f7be: Move from Quad to Cubic
Summary

See https://invent.kde.org/websites/hig-kde-org/-/merge_requests/70

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
niccolove created this revision.Mar 4 2020, 10:53 AM
Restricted Application added a project: KWin. · View Herald TranscriptMar 4 2020, 10:53 AM
niccolove requested review of this revision.Mar 4 2020, 10:53 AM
niccolove planned changes to this revision.Mar 4 2020, 10:54 AM
zzag edited reviewers, added: KWin; removed: kwin.Mar 4 2020, 11:00 AM
Restricted Application added a subscriber: kwin. · View Herald TranscriptMar 4 2020, 11:00 AM
niccolove added a comment.Mar 4 2020, 11:19 AM

I'm not sure why the changes fails to build. I managed to build it and lint errors are on files I did not change. I should try again.

apol added a subscriber: apol.EditedMar 4 2020, 11:49 AM
In D27827#621803, @niccolove wrote:

I'm not sure why the changes fails to build. I managed to build it and lint errors are on files I did not change. I should try again.

If you are talking about the cppchecks arc runs, they're bogus and always generate weird errors. I'd ignore at least all unknownMacro errors.

Regarding the patch itself, +1 LGTM.

niccolove requested review of this revision.Mar 4 2020, 3:43 PM
In D27827#621825, @apol wrote:
In D27827#621803, @niccolove wrote:

I'm not sure why the changes fails to build. I managed to build it and lint errors are on files I did not change. I should try again.

If you are talking about the cppchecks arc runs, they're bogus and always generate weird errors. I'd ignore at least all unknownMacro errors.

Gotcha.

zzag added a subscriber: zzag.Mar 4 2020, 4:03 PM

Feel free to land this patch when !70 is merged.

ngraham accepted this revision.Mar 4 2020, 6:40 PM
ngraham added a subscriber: ngraham.

LGTM.

This revision is now accepted and ready to land.Mar 4 2020, 6:40 PM
Closed by commit R108:f9394d83f7be: Move from Quad to Cubic (authored by niccolove). · Explain WhyMar 4 2020, 6:41 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 6 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 76963

View Options

autotests/integration/effects/scripted_effects_test.cpp

Loading...
View Options

libkwineffects/kwineffects.h

Loading...