Details
Details
- Reviewers
ngraham - Group Reviewers
KWin - Commits
- R108:f9394d83f7be: Move from Quad to Cubic
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Branch
- cubic (branched from master)
- Lint
Lint Errors Excuse: I didi:itI did Severity Location Code Message Error input.h:310 Cppcheck unknownMacro Error libkwineffects/kwinglobals.h:150 Cppcheck unknownMacro - Unit
No Unit Test Coverage - Build Status
Buildable 23239 Build 23257: arc lint + arc unit
Comment Actions
I'm not sure why the changes fails to build. I managed to build it and lint errors are on files I did not change. I should try again.
Comment Actions
If you are talking about the cppchecks arc runs, they're bogus and always generate weird errors. I'd ignore at least all unknownMacro errors.
Regarding the patch itself, +1 LGTM.