Differential D27827

Move from Quad to Cubic
ClosedPublic
Actions

Authored by niccolove on Mar 4 2020, 10:53 AM.

Tags

Subscribers

ngraham, zzag, apol, kwin

Details

Reviewers

Group Reviewers

Commits

R108:f9394d83f7be: Move from Quad to Cubic

Summary

See https://invent.kde.org/websites/hig-kde-org/-/merge_requests/70

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

niccolove created this revision.Mar 4 2020, 10:53 AM

Restricted Application added a project: KWin. · View Herald TranscriptMar 4 2020, 10:53 AM

niccolove requested review of this revision.Mar 4 2020, 10:53 AM

Harbormaster completed remote builds in B23239: Diff 76918.Mar 4 2020, 10:53 AM

niccolove planned changes to this revision.Mar 4 2020, 10:54 AM

zzag edited reviewers, added: KWin; removed: kwin.Mar 4 2020, 11:00 AM

Restricted Application added a subscriber: kwin. · View Herald TranscriptMar 4 2020, 11:00 AM

I'm not sure why the changes fails to build. I managed to build it and lint errors are on files I did not change. I should try again.

In D27827#621803, @niccolove wrote:

I'm not sure why the changes fails to build. I managed to build it and lint errors are on files I did not change. I should try again.

If you are talking about the cppchecks arc runs, they're bogus and always generate weird errors. I'd ignore at least all unknownMacro errors.

Regarding the patch itself, +1 LGTM.

In D27827#621825, @apol wrote:

In D27827#621803, @niccolove wrote:

I'm not sure why the changes fails to build. I managed to build it and lint errors are on files I did not change. I should try again.

If you are talking about the cppchecks arc runs, they're bogus and always generate weird errors. I'd ignore at least all unknownMacro errors.

Gotcha.

Feel free to land this patch when !70 is merged.

LGTM.

This revision is now accepted and ready to land.Mar 4 2020, 6:40 PM

Closed by commit R108:f9394d83f7be: Move from Quad to Cubic (authored by niccolove). · Explain WhyMar 4 2020, 6:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/integration/effects/scripted_effects_test.cpp (2 lines)
M			autotests/integration/effects/scripts/animationTest.js (2 lines)
M			autotests/integration/effects/scripts/animationTestMulti.js (4 lines)
M			effects/slidingpopups/slidingpopups.cpp (6 lines)
M			effects/windowaperture/package/contents/code/main.js (4 lines)
M			libkwineffects/kwineffects.h (2 lines)
M			onscreennotification.cpp (2 lines)
M			qml/outline/plasma/outline.qml (8 lines)

Diff 76963

autotests/integration/effects/scripted_effects_test.cpp

Loading...

autotests/integration/effects/scripts/animationTest.js

Loading...

autotests/integration/effects/scripts/animationTestMulti.js

Loading...

effects/slidingpopups/slidingpopups.cpp

Loading...

effects/windowaperture/package/contents/code/main.js

Loading...

libkwineffects/kwineffects.h

Loading...

onscreennotification.cpp

Loading...

qml/outline/plasma/outline.qml

Loading...