Differential D27801

smb: add a unit test for smburl
ClosedPublic
Actions

Authored by sitter on Mar 3 2020, 10:31 AM.

Details

Reviewers

ngraham

Commits

R320:d8d92670372a: smb: add a unit test for smburl

Summary

only tests some of the obvious scenarios I can see right now.

::cd() has been changed to only support going up one path element. it's
all we need it for and the previous code was almost certainly incorrect
by calling setUrl with input that is definitely not anywhere near a valid
url

Test Plan

builds and test passes

Diff Detail

Repository

R320 KIO Extras

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

sitter created this revision.Mar 3 2020, 10:31 AM

Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptMar 3 2020, 10:31 AM

Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript

sitter requested review of this revision.Mar 3 2020, 10:31 AM

Harbormaster completed remote builds in B23175: Diff 76832.Mar 3 2020, 10:31 AM

apol added a subscriber: apol.Mar 3 2020, 2:41 PM

apol added inline comments.

smb/smburl.cpp
67	Can't we then just rename the method to `::cdUp()`?

sitter mentioned this in D27800: smb: split module into two targets of which one is a static lib.Mar 3 2020, 3:56 PM

follow Aleix' suggestion and change cd() to cdUp() seeing as it now only cds up

Harbormaster completed remote builds in B23195: Diff 76861.Mar 3 2020, 3:59 PM

+1 from me

smb/smburl.cpp
67	it can return void too, nobody is checking it anyway.

make cdup void

Harbormaster completed remote builds in B23250: Diff 76935.Mar 4 2020, 1:41 PM

ngraham accepted this revision.Mar 4 2020, 6:52 PM

This revision is now accepted and ready to land.Mar 4 2020, 6:52 PM

Closed by commit R320:d8d92670372a: smb: add a unit test for smburl (authored by sitter). · Explain WhyMar 6 2020, 4:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		smb/CMakeLists.txt (2 lines)
A	M	smb/autotests/CMakeLists.txt (17 lines)
A	M	smb/autotests/smburltest.cpp (69 lines)
M		smb/kio_smb_browse.cpp (2 lines)
M		smb/smburl.h (2 lines)
M		smb/smburl.cpp (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	76832	55feaa8		Mar 3 2020, 10:31 AM	★	★
Diff 2	76861	55feaa8	follow Aleix' suggestion and change cd() to cdUp() seeing as it now only cds up	Mar 3 2020, 3:59 PM	★	★
Diff 3	76935	55feaa8	make cdup void	Mar 4 2020, 1:41 PM	★	★
Diff 4	77119	d101d91	R320:d8d92670372a4548624f23ef6095a558cb08c646	Mar 6 2020, 4:13 PM	★	★