Fix for not try to check error or try to disconnect if there isn't m_deviceToTearDown exist
AcceptedPublic

Authored by usta on Feb 29 2020, 11:03 AM.

Details

Reviewers
ngraham
meven
elvisangelaccio
Group Reviewers
Dolphin
Summary

Currently, when you try to Eject a CD/DVD from the system it gives an error like :
QObject::disconnect: Unexpected nullptr parameter
because m_deviceToTearDown is already nullptr before reaching that disconnect

Diff Detail

Repository
R318 Dolphin
Lint
Lint Skipped
Unit
Unit Tests Skipped
usta created this revision.Feb 29 2020, 11:03 AM
Restricted Application added a project: Dolphin. · View Herald TranscriptFeb 29 2020, 11:03 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
usta requested review of this revision.Feb 29 2020, 11:03 AM
ngraham accepted this revision.Mar 1 2020, 2:10 PM
ngraham added reviewers: meven, elvisangelaccio.
This revision is now accepted and ready to land.Mar 1 2020, 2:10 PM
usta added a comment.Mar 1 2020, 3:18 PM

Could anyone commit it for me because i didnt make my setup on my box yet. ( planing yo switch to a new laptop thus didnt setup my current git configuration yet ( certificates) )

On my Arch virtual machine, if I have the terminal open when ejecting an optical disc (working directory in the disc), dolphin doesn't do anything. It probably returned too early or m_deviceToTearDown is falsely set to nullptr for some reason.

usta added a comment.Mar 1 2020, 5:45 PM

On my Arch virtual machine, if I have the terminal open when ejecting an optical disc (working directory in the disc), dolphin doesn't do anything. It probably returned too early or m_deviceToTearDown is falsely set to nullptr for some reason.

did you try on a non mounted dvd ?

usta added a comment.Mar 1 2020, 5:46 PM

btw if needed i can send a screen record about this

usta added a comment.Mar 1 2020, 6:35 PM

i will try to dig in a little more tonight when i return back to house

because m_deviceToTearDown is already nullptr before reaching that disconnect

Why is it null?
The only place where we set m_deviceToTearDown to null is slotStorageTearDownDone(). Can you check whether this function is being called twice?

usta added a comment.Oct 13 2020, 6:49 PM

@ngraham pong :) sorry i have completely forgotten this after invent migration. On the other hand i have just changed my harddrive to ssd and planing to install my kde dev system tonight or morning.
After than that i will first check @elvisangelaccio 's suggestion and then move this one into invent and make mr in there

np, sounds good.