Use QStringLiteral
ClosedPublic
Actions

Authored by nicolasfella on Feb 27 2020, 4:33 PM.

Details

Reviewers

Group Reviewers

Frameworks

Commits

R155:be294dcc69e7: Use QStringLiteral

Summary

Don't use naked strings

Test Plan

builds

Repository

R155 KAccounts Integration

Branch

qsl

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 23025
Build 23043: arc lint + arc unit

nicolasfella requested review of this revision.Feb 27 2020, 4:33 PM

nicolasfella created this revision.

Remove unintended changes

Remove unintended change

if you want to have this, it could make sense to enforce it from cmake.

src/jobs/createaccount.cpp
195	Use QLatin1Char here.

This revision is now accepted and ready to land.Feb 28 2020, 9:44 AM

This revision was automatically updated to reflect the committed changes.

nicolasfella marked an inline comment as done.Feb 28 2020, 11:02 AM

			Path	Packages
M			CMakeLists.txt (12 lines)
M			src/jobs/createaccount.cpp (16 lines)
M			src/kcm/accounts.cpp (6 lines)
M			src/lib/getcredentialsjob.cpp (2 lines)
M			src/lib/uipluginsmanager.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	76563	26a4a89		Feb 27 2020, 4:33 PM	★	★
Diff 2	76565	26a4a89	Remove unintended changes	Feb 27 2020, 4:37 PM	★	★
Diff 3	76566	26a4a89	Remove unintended change	Feb 27 2020, 4:39 PM	★	★
Diff 4	76610	2030bb4	R155:be294dcc69e7a8c68f725b26daf2de0a1ffe9c04	Feb 28 2020, 11:02 AM	★	★