Differential D27596

Load QM files from assets: URLs on Android
ClosedPublic
Actions

Authored by vkrause on Feb 23 2020, 12:42 PM.

Details

Reviewers
apol
Maniphest Tasks
T12520: Qt 5.14
Commits
R240:040504da64aa: Load QM files from assets: URLs on Android
Summary

This works with both the old and the new way of Qt's asset deployment, ie.
with Qt 5.13 and Qt 5.14.

Diff Detail

Repository
R240 Extra CMake Modules
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Feb 23 2020, 12:42 PM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptFeb 23 2020, 12:42 PM
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript
vkrause requested review of this revision.Feb 23 2020, 12:42 PM
apol added a subscriber: apol.Feb 23 2020, 11:33 PM

Don't we need an if Qt 5.13 elseif Qt 5.14?

In other Qt versions it won't be in the assets...

vkrause added a comment.Feb 24 2020, 5:29 PM
In D27596#616554, @apol wrote:

Don't we need an if Qt 5.13 elseif Qt 5.14?

In other Qt versions it won't be in the assets...

Are you sure about this? I had tested this on my Qt 5.13 setup and the files are in the same place there. I can't prove it with the binary factory apk though, translations don't seem to be included there at all?

apol accepted this revision.Feb 24 2020, 5:57 PM

They used to work back when I added the code for it. Maybe it broke over time. If it works for you, go for it.

This revision is now accepted and ready to land.Feb 24 2020, 5:57 PM
Closed by commit R240:040504da64aa: Load QM files from assets: URLs on Android (authored by vkrause). · Explain WhyFeb 26 2020, 5:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmodules/ECMQmLoader.cpp.in (2 lines)

Diff 76476

View Options

modules/ECMQmLoader.cpp.in

Loading...