Differential D27562

[kcmcontrols] Respect header/footer visibility
ClosedPublic
Actions

Authored by nicolasfella on Feb 22 2020, 1:05 AM.

Details

Reviewers
mart
ngraham
Group Reviewers
Plasma
Commits
R296:0dad857cddfb: [kcmcontrols] Respect header/footer visibility
Summary

Sometimes we want the header/footer to be invisible by default, e.g. a Kirigami.InlineMessage that only appears on some error condition.

Same as 1270e357a96f1e78281c0335b1bd05e5c9c3e3c6 but for ScrollViewKCM/GridViewKCM

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Feb 22 2020, 1:05 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 22 2020, 1:05 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Feb 22 2020, 1:05 AM
nicolasfella updated this revision to Diff 76136.Feb 22 2020, 1:12 AM
  • Do same for GridViewKCM
nicolasfella retitled this revision from [scrollviewkcm] Respect header/footer visibility to [kcmcontrols] Respect header/footer visibility.Feb 22 2020, 1:13 AM
nicolasfella edited the summary of this revision. (Show Details)
nicolasfella edited the summary of this revision. (Show Details)Feb 22 2020, 9:44 AM
ngraham accepted this revision.Mar 8 2020, 4:10 PM
This revision is now accepted and ready to land.Mar 8 2020, 4:10 PM
Closed by commit R296:0dad857cddfb: [kcmcontrols] Respect header/footer visibility (authored by nicolasfella). · Explain WhyMar 8 2020, 4:21 PM
This revision was automatically updated to reflect the committed changes.
nicolasfella mentioned this in R116:83ce03a41117: [mobile/wifi] Use ScrollViewKCM.

Revision Contents
Changeset List

Diff 77221

View Options

src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml

Loading...
View Options

src/qmlcontrols/kcmcontrols/qml/ScrollViewKCM.qml

Loading...