fix margins in OverlaySheet
Concern Raised2cea7b4781c9

Authored by mart on Feb 19 2020, 10:57 AM.

Description

fix margins in OverlaySheet

Details

Auditors
davidedmundson
Committed
martFeb 19 2020, 10:57 AM
Parents
R169:2d5674da7b60: [examples/simplechatapp] Always set isMenu to true
Branches
Unknown
Tags
Unknown
davidedmundson raised a concern with this commit.Feb 20 2020, 1:04 AM
davidedmundson added a subscriber: davidedmundson.

From the mailing list thread:

Re: 2 kirigami fixes for a point release

> Kirigami seems to be rather unstable, I wonder if anything can be done to
> improve upon that [*].

One important thing seems to have been getting sloppy in those repos;
mandatory code reviews.
That's an easy thing to enforce, and we know it makes a huge difference to
code.

Even if no-one comments, the extra delay of it running on your own
system delivers a lot.

I fully agree.

(CC'ing the developer lists)

This commit now has outstanding concerns.Feb 20 2020, 1:04 AM