- Allow to manage controller externally
- Compatible (for checkbox) with KConfigDialogManager (usage of kcfg_ in widget name)
- Expose loader and settings in order to allow them to be managed by a KCModule
Details
- Reviewers
ervin crossi meven - Group Reviewers
Plasma - Commits
- R246:12d1e200f081: Create ConfigView an unmanaged ConfigWidget
- automated test
- Checked integration with Kate
- ConfigView tested with a plasma-desktop patch
Diff Detail
- Repository
- R246 Sonnet
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
src/core/loader_p.h | ||
---|---|---|
7 | What's the reason for loader becoming public? If that's mostly out of convenience (it looks like it is), I'd advise not turning it public, Settings and ConfigView can use it internally but let's not increase the API surface even more with Loader. | |
src/core/settings.cpp | ||
13 | Obviously will reappear here ;-) | |
63–64 | This is an odd bit of logic, isn't it? | |
69 | Ditto | |
src/core/settings.h | ||
10 | Please remove that include (it'll become more obvious why you'll be able to do it with one of the comments below) ;-) | |
34 | Will need a ctor (see other comments) in the form of explicit Settings(QObject *parent = nullptr); | |
37 | This is likely useless now, since we inherit from QObject and QObject is non-copyable | |
38 | Ditto | |
80 | Move all the implementations of those static methods to the cpp file. | |
137 | Time to move those to the SettingsPrivate class. | |
142 | Might end up disappearing completely, unsure but to be evaluated | |
src/core/speller.cpp | ||
216 | And that negation again? We're negating twice now... | |
232 | And again... I wonder what's happening there, it's highly confusing. | |
src/ui/configview.cpp | ||
34 | I'm kind of surprised at this extra widget, can't we get rid of it? | |
src/ui/configview.h | ||
18 | Please move this line just after the #include <QWidget> | |
24 | You might want to declare a bunch of Q_PROPERTY there | |
26 | clients should be a const reference (although I suspect it'll disappear) parent should be the last parameter and default to nullptr | |
27 | override | |
31 | All the setters there would make for good public slots | |
35 | Space before & not after | |
40 | Are they directly called by a subclass outside the library? If not move them to the dpointer and use Q_PRIVATE_SLOT | |
43 | Move to the d pointer and use Q_PRIVATE_SLOT for those | |
56 | Should be in the d pointer |
src/core/settings.cpp | ||
---|---|---|
63–64 | Yes indeed, but what we want is to save false if checked and true if not checked. | |
src/ui/configview.cpp | ||
34 | I kept same widget logic as ConfigWidget. Ididn't want to change that to ensure we have the same baheviour |