Drop KToolInvocation support from KRun::runService
ClosedPublic

Authored by davidedmundson on Feb 17 2020, 8:56 AM.

Details

Summary

This drops the use of kinit as per T12140. Few applications link to
kdeinit correctly and the potential savings that come from library
linking are now negligible.

We use the internal app spawning path for the majority of application
launches anyway via the relatively new KRun::runApplication. There isn't
a need for runService to support a more complex addition path.

It will also simplify any future changes coming to KRun.

Test Plan

Opened a file from kicker's recently used selection (which uses this runService)
It opened as normal, with correct startup notifications

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Feb 17 2020, 8:56 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 17 2020, 8:56 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Feb 17 2020, 8:56 AM
ervin added a subscriber: ervin.Feb 17 2020, 12:51 PM

For the record, it LGTM and I'm glad to see this point discussing during the sprint coming through. :-)

Remove extra include

dfaure accepted this revision.Feb 22 2020, 8:34 AM

This makes runService and runApplication almost the same, right?

KRecentDocument::add seems missing in runApplication, but that's a bug, so one could just call the other?

This revision is now accepted and ready to land.Feb 22 2020, 8:34 AM

This makes runService and runApplication almost the same, right?

Yeah, that was the goal.

KRecentDocument::add seems missing in runApplication, but that's a bug

If that is a bug, then we may as well share the implementation. I'll do that.

This revision was automatically updated to reflect the committed changes.