[Applet]Fix details layout.
ClosedPublic

Authored by gvgeo on Feb 14 2020, 7:14 AM.

Details

Summary

Fix binding loop with detailValueLabel's width.
Remove workaround for contentRect height.
Use Column as root item.
Remove unused topMargin.

Test Plan

Details of connections must remain the same.

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gvgeo created this revision.Feb 14 2020, 7:14 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 14 2020, 7:14 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gvgeo requested review of this revision.Feb 14 2020, 7:14 AM
gvgeo added a comment.Feb 14 2020, 7:15 AM

This patch keeps left margins and opacity.

Can we not make the Column the root item of the component? Then it should propagate the size automatically.

gvgeo updated this revision to Diff 75673.Feb 14 2020, 10:59 AM

Used Column as root item.

gvgeo updated this revision to Diff 75674.Feb 14 2020, 11:01 AM

Removed empty line.

gvgeo edited the summary of this revision. (Show Details)Feb 14 2020, 11:04 AM
gvgeo edited the test plan for this revision. (Show Details)
gvgeo edited the summary of this revision. (Show Details)

Might be nice to port to ColumnLayout while we're at it

gvgeo added a comment.Feb 14 2020, 5:30 PM

Might be nice to port to ColumnLayout while we're at it

It is not really possible, what makes sense is changing to GridLayout. But because is a similar situation with battery's info bug, I don't want to do it together with these patches.
D26806#inline-151955 (Line 96 in code now)

ngraham accepted this revision.Feb 14 2020, 6:42 PM
gvgeo updated this revision to Diff 75769.Feb 16 2020, 2:51 PM

Remove unnecessary anchors.

jgrulich accepted this revision.Feb 17 2020, 2:17 PM
This revision is now accepted and ready to land.Feb 17 2020, 2:17 PM
This revision was automatically updated to reflect the committed changes.