Fix DESTDIR usage
ClosedPublic

Authored by arojas on Feb 11 2020, 6:46 PM.

Details

Summary

kajongg's build system uses DESTDIR during cmake to construct the command that creates the kajongg and kajonggserver symlinks in bindir. This is a problem for distributions, which usually have separated ckame/make/make install stages with DESTDIR only available in the later one. So distros are currently working around this in different ways, either creating the symlinks manually after make install (Gentoo, Fedora) or defining DESTDIR before running cmake (Arch, Opensuse).
This patch changes the symlink installation process to only make the DESTDIR substitution during make install.

Test Plan

cmake && make && make DESTDIR=foo install, symlinks are correctly created inside foo.

Diff Detail

Repository
R387 Kajongg
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arojas created this revision.Feb 11 2020, 6:46 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald TranscriptFeb 11 2020, 6:46 PM
arojas requested review of this revision.Feb 11 2020, 6:46 PM
asturmlechner accepted this revision.Wed, Mar 25, 6:25 PM

Works for me!

This revision is now accepted and ready to land.Wed, Mar 25, 6:25 PM
This revision was automatically updated to reflect the committed changes.