KCM KWinTabBox port to KConfigXT : use generated kcfg settings to load and save config
ClosedPublic

Authored by crossi on Feb 11 2020, 3:09 PM.

Diff Detail

Repository
R108 KWin
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 22370
Build 22388: arc lint + arc unit
crossi created this revision.Feb 11 2020, 3:09 PM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 11 2020, 3:09 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
crossi requested review of this revision.Feb 11 2020, 3:09 PM
crossi added a reviewer: KWin.Feb 11 2020, 3:24 PM
zzag added a subscriber: zzag.Feb 11 2020, 3:59 PM
zzag added inline comments.
kcmkwin/kwintabbox/kwinpluginssettings.kcfg
16

Do we actually need code="true"?

crossi updated this revision to Diff 75481.Feb 11 2020, 4:11 PM

remove unneeded code attribute.

crossi marked an inline comment as done.Feb 11 2020, 4:12 PM
zzag accepted this revision.Feb 11 2020, 4:37 PM

+1

kcmkwin/kwintabbox/main.h
73–74

Minor nitpick: it seems like there's no any reason to pass config by reference now. At each call site, we de-reference a settings object. I suggest to pass config by pointer.

This revision is now accepted and ready to land.Feb 11 2020, 4:37 PM
meven accepted this revision.Feb 11 2020, 5:47 PM
crossi updated this revision to Diff 75551.Feb 12 2020, 2:23 PM

pass by pointer instead of ref

crossi marked an inline comment as done.Feb 12 2020, 2:24 PM
ervin accepted this revision.Feb 12 2020, 4:30 PM
bport accepted this revision.Feb 18 2020, 1:05 PM
This revision was automatically updated to reflect the committed changes.