[Folder view]Make shadow scale aware
Needs ReviewPublic

Authored by gvgeo on Tue, Feb 11, 11:14 AM.

Details

Reviewers
None
Group Reviewers
Plasma
VDG
Summary

Added devicePixelRatio to shadow's radius.

Test Plan

Check the shadow of items on the desktop.
Compare scale 100% vs big display scale (e.g. 300%).
Before: Shadow is invisible.
After: Visible shadow at every display scale.

Before vs After
Scale 300% and 100%

Diff Detail

Repository
R119 Plasma Desktop
Branch
shadow2 (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22365
Build 22383: arc lint + arc unit
gvgeo created this revision.Tue, Feb 11, 11:14 AM
Restricted Application added a project: Plasma. · View Herald TranscriptTue, Feb 11, 11:14 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gvgeo requested review of this revision.Tue, Feb 11, 11:14 AM
gvgeo edited the test plan for this revision. (Show Details)Tue, Feb 11, 11:17 AM
gvgeo updated this revision to Diff 75453.Tue, Feb 11, 11:30 AM
gvgeo edited the test plan for this revision. (Show Details)

Enclosed in Math.round()
Although works fine without it.

Oh gosh, are shadows not scale-aware anywhere? We'd have to replicate this code in a lot of places... might it make more sense to fix this in Qt itself?

gvgeo updated this revision to Diff 75476.Tue, Feb 11, 3:17 PM
gvgeo added a reviewer: VDG.

Rebase.

gvgeo added a comment.Tue, Feb 11, 4:44 PM

Shadows look fine in wayland. Like many other elements, the problem is with X11.