Diff Detail
- Repository
- R266 Breeze Icons
- Branch
- kirigami_galery (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 27122 Build 27140: arc lint + arc unit
You've got a duplicate copy of the icon in there. The bottom shadow should also be changed to be dark gray, like a darker version of the normal background color rather than a dark blue.
I have no Idea why the diff deletes the ktrip icon.
unfortunately I cant fix that because I have no Idea how to do that with git.
You can try to execute this git command to solve this problem :)
git checkout origin/master icons/apps/48/ktrip.svg
Sorry this got lost.
Still looks kinda jaggy to me though, especially at 48px.:
Do you think you could clean up the outline a bit?
Sorry this got lost.
Still looks kinda jaggy to me though, especially at 48px.:
Do you think you could clean up the outline a bit?
Just to give some direction, I've found that the easiest way to fix these kinds of issues is to cut away the outside edge of the part that is sticking out. In theory, making shapes overlap perfectly should prevent the covered bits from showing. In practice, SVG renderers sometimes draw an outline of the part underneath around the part that is above.
@mbruchert Sorry I forgot about this. In the future, if an icon patch you made is sitting around waiting for review, feel free to notify me on Telegram (@noahdvs) or on Matrix (@noahdvs:kde.org) in the VDG channel.
can we fix this and go ahead?
@mbruchert can you still work on it? want to put it on invent?
I noticed that the lighting in this version of the Kirigami is flipped. Is that intentional? I don't think it makes sense for the top of the K popout to be darker than the bottom. Since the light in Breeze icons comes from the top left, the top should be light, like in the original Kirigami icon.
I think I'd prefer to keep this similar to the original Kirigami icon. Do you mind if I commandeer this? I've already made the changes.