Differential D27155

libnotificationmanager : add app-specific kconfig settings
ClosedPublic
Actions

Authored by crossi on Feb 4 2020, 3:27 PM.

Details

Reviewers
ervin
broulik
bport
meven
Commits
R120:c56e12cc540d: libnotificationmanager : add app-specific kconfig settings
Summary

Provide a kcfg for app-specific notifications with kconfig. Require D27059 and D27133

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
crossi created this revision.Feb 4 2020, 3:27 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 4 2020, 3:27 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
crossi requested review of this revision.Feb 4 2020, 3:27 PM
broulik added a comment.Feb 5 2020, 8:26 AM

Not a fan of all that code in the default part. The idea was to install a rules file by default (like libtaskmanager does) which can then be tweaked and/or overridden.

crossi planned changes to this revision.Feb 5 2020, 3:51 PM

Will remove the defaults and rely on the rules file.

crossi updated this revision to Diff 75090.Feb 6 2020, 10:19 AM

Remove specific default values, will rely on shipped settings. Fix comment at EOL that makes the entry not read.

bport accepted this revision.Feb 10 2020, 8:12 AM
This revision is now accepted and ready to land.Feb 10 2020, 8:12 AM
ervin accepted this revision.Feb 12 2020, 1:55 PM
crossi updated this revision to Diff 76834.Mar 3 2020, 10:38 AM

use parentGroup attribute

ervin accepted this revision.Mar 5 2020, 3:01 PM

Although might become "parentGroupName" depending on what you do about my comments on the review introducing sub-group handling.

crossi updated this revision to Diff 77068.Mar 6 2020, 8:33 AM

rename group attribute to parentGroupName

ervin accepted this revision.Mar 6 2020, 10:18 AM
meven accepted this revision.Apr 20 2020, 3:07 PM
Closed by commit R120:c56e12cc540d: libnotificationmanager : add app-specific kconfig settings (authored by crossi). · Explain WhyApr 22 2020, 7:51 AM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 4 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 80845