Use ecm_qt_install_logging_categories over manual categories file
ClosedPublic
Actions

Authored by kossebau on Feb 4 2020, 5:30 AM.

Details

Reviewers

broulik
mlaurent

Group Reviewers

Build System
Frameworks

Commits

Test Plan

Diff of generated file matches existing file, besides additional header

Repository

R244 KCoreAddons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

kossebau requested review of this revision.Feb 4 2020, 5:30 AM

Seems ok for me.

This revision is now accepted and ready to land.Feb 4 2020, 6:48 AM

This revision was automatically updated to reflect the committed changes.

		Path
M		CMakeLists.txt (2 lines)
D	M	kcoreaddons.categories (6 lines)
M		src/lib/CMakeLists.txt (43 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	74974	ee3eaa8		Feb 4 2020, 5:30 AM	★	★
Diff 2	75422	7bc9d98	R244:fcb1eff1c610b4894c5c8469668725be02be8cfd	Feb 11 2020, 12:44 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
d1fb1304c071	1a41693d1e32	ee3eaa881c07	Friedrich W. H. Kossebau	Use ecm_qt_install_logging_categories over manual categories file (Show More…)	Feb 4 2020, 5:29 AM

Status	Author	Revision
Closed	kossebau	D27178 Use ecm_qt_install_logging_categories over manual categories file
Closed	kossebau	D27269 Use ecm_qt_install_logging_categories over manual categories file
Closed	kossebau	D27270 Use ecm_qt_install_logging_categories over manual categories files
Closed	kossebau	D27151 Use ecm_qt_install_logging_categories over manual categories file
Closed	kossebau	D27150 Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category