Use ecm_qt_install_logging_categories over manual categories file
ClosedPublic
Actions

Authored by kossebau on Feb 5 2020, 9:16 PM.

Details

Reviewers

broulik
mlaurent

Group Reviewers

Build System
Frameworks

Commits

R246:19cd6b195279: Use ecm_qt_install_logging_categories over manual categories file

Test Plan

Entries of generated file match existing file, besides order and
header comments, unless plugin not build, and also for
ISpellChecker & NSSpellChecker (missing so far)

Diff Detail

Repository

R246 Sonnet

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau created this revision.Feb 5 2020, 9:16 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 5 2020, 9:16 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

kossebau requested review of this revision.Feb 5 2020, 9:16 PM

Harbormaster completed remote builds in B22106: Diff 75070.Feb 5 2020, 9:16 PM

Another example, here with categories declared in different directories, yet a single place where the categories file is generated and installed.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 11 2020, 1:05 AM

Closed by commit R246:19cd6b195279: Use ecm_qt_install_logging_categories over manual categories file (authored by kossebau). · Explain Why

This revision was automatically updated to reflect the committed changes.

bruns added a subscriber: bruns.Feb 28 2020, 10:30 PM

bruns added inline comments.

CMakeLists.txt
7	Obviously, this is no longer true. This now depends on an unreleased ECM version ...

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (3 lines)
D	M	sonnet.categories (8 lines)
M		src/CMakeLists.txt (6 lines)
M		src/core/CMakeLists.txt (8 lines)
M		src/plugins/aspell/CMakeLists.txt (8 lines)
M		src/plugins/hspell/CMakeLists.txt (8 lines)
M		src/plugins/hunspell/CMakeLists.txt (8 lines)
M		src/plugins/ispellchecker/CMakeLists.txt (8 lines)
M		src/plugins/nsspellchecker/CMakeLists.txt (5 lines)
M		src/plugins/voikko/CMakeLists.txt (8 lines)
M		src/ui/CMakeLists.txt (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	75070	266c8f7		Feb 5 2020, 9:16 PM	★	★
Diff 2	75424	71e20ed	R246:19cd6b195279e4caf0a211f4611f856f990cc9b1	Feb 11 2020, 1:05 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
8288127c8933	d54b29b98f2a	266c8f7577b2	Friedrich W. H. Kossebau	Use ecm_qt_install_logging_categories over manual categories file (Show More…)	Feb 5 2020, 9:14 PM

Status	Author	Revision
Closed	kossebau	D27151 Use ecm_qt_install_logging_categories over manual categories file
Closed	kossebau	D27269 Use ecm_qt_install_logging_categories over manual categories file
Closed	kossebau	D27270 Use ecm_qt_install_logging_categories over manual categories files
Closed	kossebau	D27178 Use ecm_qt_install_logging_categories over manual categories file
Closed	kossebau	D27150 Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category