To make clear to the user what automount options imply.
Details
Details
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- onattabch
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 22004 Build 22022: arc lint + arc unit
| solid-device-automounter/kcm/DeviceModel.cpp | ||
|---|---|---|
| 189–190 | This logic is becoming harder to read than necessary. I think I would go for something structured along those lines: if (!index.parent().isValid()) {
return Qt::ItemIsEnabled;
}
switch (index.column()) {
case 0:
...
case 1:
...
case 2:
...
default:
Q_UNREACHABLE
} | |
| 366 | { Should be on its own line | |
| 375 | Ditto + needs an empty line before that one. | |
Comment Actions
Conceptually +1.
It's not related to this patch, but looking at the table, it would be nice to move from a tree view into a list view with section headers, like how the GLobal Shortcuts KCM does.