The border radius is slightly different because I copied what Kirigami does for the inner rect but I can also go back to radius 4

In D27035#603375, @davidre wrote:

The border radius is slightly different because I copied what Kirigami does for the inner rect but I can also go back to radius 4

Nevermind that was because of above mistake

Does that also work in Kate for floating messages like when the search wraps? What I want to know is whether the corners behind the green frame are transparent in this case, or whether the corners are painted solid. If I remember correctly, these kind of bugs were the reason to use Qt StyleSheets. And it must work with all styles.

Please do NOT yet commit, especially since we'd only have two days of testing period: Saturday, 1st of February is the next frameworks tag.

Can you provide screenshots of more styles? :-)

In D27035#603460, @dhaumann wrote:

Does that also work in Kate for floating messages like when the search wraps? What I want to know is whether the corners behind the green frame are transparent in this case, or whether the corners are painted solid. If I remember correctly, these kind of bugs were the reason to use Qt StyleSheets. And it must work with all styles.

Please do NOT yet commit, especially since we'd only have two days of testing period: Saturday, 1st of February is the next frameworks tag.

Should or shouldn't it be transparent? Also I don't understand which part should be transparent and which shouldn't? The border was never transparent and the background also not. Screenshots:

In D27035#603462, @dhaumann wrote:

Can you provide screenshots of more styles? :-)

Of course:
Adwaita

In D27035#603460, @dhaumann wrote:

Does that also work in Kate for floating messages like when the search wraps? What I want to know is whether the corners behind the green frame are transparent in this case, or whether the corners are painted solid. If I remember correctly, these kind of bugs were the reason to use Qt StyleSheets. And it must work with all styles.

Please do NOT yet commit, especially since we'd only have two days of testing period: Saturday, 1st of February is the next frameworks tag.

Sorry forgot the screenshots, but you're right the text shines through now in KTextEditor and it doesn't seem to positioned correctly. For the first one I could go back to mixing the color manually instead of just drawing it with an alpha of 0.2. I will look into the second issue

Kate with this patch and Oxygen style:

Better :) with corners I mean the 1-3 pixels left due to the rounding corners. These pixels were once also drawn as background although they are outside of the frame. It may be a minor detail, but imho such details are important. But indeed, the screenshots look good.

Next test: open a file in kate. Now either change the file externally or delete it. Kate should show an animated KMessageWidget. Does it also correctly work with a small kate? I.e. small width of kate window?

In D27035#603619, @dhaumann wrote:

Better :) with corners I mean the 1-3 pixels left due to the rounding corners. These pixels were once also drawn as background although they are outside of the frame. It may be a minor detail, but imho such details are important. But indeed, the screenshots look good.

Next test: open a file in kate. Now either change the file externally or delete it. Kate should show an animated KMessageWidget. Does it also correctly work with a small kate? I.e. small width of kate window?

It seems to work better than before, on the left the current one, on the right this patch:

In D27035#604026, @ngraham wrote:

Uh-oh, now it looks like this in Konsole:

Compare to the current appearance:

I recall wrestling with this issue in D12508. Might be worth looking over that.

That's because it wants to look transparent and mixes the background color with its color. One fix could be to also use the parent's text color (in this case white) or stop using QPalette::Window for data storage and mix with the window color of the widget's palette and use something else (maybe QPalette::Base). Opinions?

Something like this:

Ping, how should I proceed?

In D27035#604158, @davidre wrote:

Something like this:

That would be fine, yes.

In the current code I took the approach of always using the system color scheme even if the local view overrode it, as Konsole does. Using the view's local color scheme isn't incorrect, just different. Arguably it's more correct. I say go for it if you think it makes sense.

+1 code looks much better!

So I think this is ready to be merged and I would do so this weekend