Reduce Activity Pager to .desktop file referencing the Pager package.
ClosedPublic
Actions

Authored by hein on Sep 6 2016, 10:13 AM.

Details

Reviewers

davidedmundson
mart

Group Reviewers

Plasma

Commits

Summary

Depends on D2676.

Repository

R114 Plasma Addons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

hein retitled this revision from to Reduce Activity Pager to .desktop file referencing the Pager package..

hein updated this object.

hein edited the test plan for this revision. (Show Details)

hein added a subscriber: plasma-devel.

yes please :D (after D2676 of course)

This revision is now accepted and ready to land.Sep 6 2016, 11:32 AM

davidedmundson edited edge metadata.

This revision was automatically updated to reflect the committed changes.

CMake Error at applets/activitypager/cmake_install.cmake:36 (file):

file INSTALL cannot find
"/home/kaiuwe/Projekte/kf5/kdeplasma-addons/applets/activitypager/metadata.desktop".

As many others have noted already, the .desktop file is missing in this diff, and that broke kdeplasma-addons build.

Sorry, got too enthusiastic with all the deleting maybe ;). Fixed now.

		Path
M		applets/activitypager/CMakeLists.txt (30 lines)
D	M	applets/activitypager/Messages.sh (3 lines)
D	M	applets/activitypager/package/contents/code/utils.js (6 lines)
D	M	applets/activitypager/package/contents/config/config.qml (29 lines)
D	M	applets/activitypager/package/contents/config/main.xml (32 lines)
D	M	applets/activitypager/package/contents/ui/configGeneral.qml (136 lines)
D	M	applets/activitypager/package/contents/ui/main.qml (352 lines)
D	M	applets/activitypager/package/metadata.desktop (82 lines)
D	M	applets/activitypager/plugin/activitypager.h (167 lines)
D	M	applets/activitypager/plugin/activitypager.cpp (612 lines)
D	M	applets/activitypager/plugin/activitypagerplugin.h (35 lines)
D	M	applets/activitypager/plugin/activitypagerplugin.cpp (29 lines)
D	M	applets/activitypager/plugin/model.h (112 lines)
D	M	applets/activitypager/plugin/model.cpp (250 lines)
D	M	applets/activitypager/plugin/qmldir (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	6475	1c4991e		Sep 6 2016, 10:12 AM	★	★
Diff 2	6497	1c4991e	rKDEPLASMAADDONSa4bd3e75fe1cafddf24bdf293a97fba7f20e1538	Sep 6 2016, 10:13 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
1a817fe22fae	46bb9c664658	1c4991ec4552	Eike Hein	Reduce Activity Pager to .desktop file referencing the Pager package. (Show More…)	Sep 6 2016, 10:11 AM

Status	Author	Revision
Closed	hein	D2677 Reduce Activity Pager to .desktop file referencing the Pager package.
Closed	hein	D2676 Improved and optimized Pager and Activity Pager
Closed	hein	D2675 Add desktop layout rows property.
Closed	hein	D2674 Add optional filtering by SkipPager window state.