Differential D26732

Use QDesktopServices to open urls not supported by dolphin
ClosedPublic
Actions

Authored by meven on Jan 17 2020, 5:12 PM.

Tags

Subscribers

nicolasfella, kfm-devel

Details

Reviewers

elvisangelaccio
ngraham

Group Reviewers

Commits

R318:17e1a48c6800: Use QDesktopServices to open urls not supported by dolphin

Summary

This improves portability.
QDesktopServices uses standard mimetype base resolution to find the app to use.

BUG: 372642
FIXED-IN: 20.04

Test Plan

Open http://google.com, opened default web browser
Open mms:// (on my test system opened vlc)

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

meven created this revision.Jan 17 2020, 5:12 PM

Restricted Application added a project: Dolphin. · View Herald TranscriptJan 17 2020, 5:12 PM

Restricted Application added a subscriber: kfm-devel. · View Herald Transcript

meven requested review of this revision.Jan 17 2020, 5:12 PM

Harbormaster completed remote builds in B21286: Diff 73783.Jan 17 2020, 5:12 PM

+1

Very nice, much simpler than D18838 ;)

This should fix https://bugs.kde.org/show_bug.cgi?id=372642 right?

In D26732#596906, @elvisangelaccio wrote:

Very nice, much simpler than D18838 ;)

This should fix https://bugs.kde.org/show_bug.cgi?id=372642 right?

Yes

elvisangelaccio accepted this revision.Jan 19 2020, 10:10 PM

This revision is now accepted and ready to land.Jan 19 2020, 10:10 PM

meven edited the summary of this revision. (Show Details)Jan 20 2020, 9:29 AM

Ensure the url navigator matches the current path

Harbormaster completed remote builds in B21375: Diff 73918.Jan 20 2020, 9:43 AM

ngraham accepted this revision.Jan 20 2020, 3:19 PM

Finally found the code in qt that handles this behind the scene : https://code.woboq.org/qt5/qtbase/src/platformsupport/services/genericunix/qgenericunixservices.cpp.html#59

Closed by commit R318:17e1a48c6800: Use QDesktopServices to open urls not supported by dolphin (authored by meven). · Explain WhyJan 20 2020, 3:50 PM

This revision was automatically updated to reflect the committed changes.

meven mentioned this in D18838: Fix opening http links in browser.Jan 21 2020, 11:23 AM

Revision Contents
Changeset List

			Path	Packages
M			src/dolphinviewcontainer.cpp (19 lines)

Diff 73954

src/dolphinviewcontainer.cpp

Loading...