add gpu entry to about system

Authored by sitter on Jan 16 2020, 3:06 PM.



simply queries gl_renderer from gl

also refactor string processing for (R) and (TM) replacement so
it can be shared for cpu and gpu entries

I do wonder if we need to blacklist software gl somehow though

BUG: 355053
FIXED-IN: 5.19.0

Test Plan

shows something of value on amd and intel

depends on D26667

Diff Detail

R102 KInfoCenter
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Jan 16 2020, 3:06 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 16 2020, 3:06 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Jan 16 2020, 3:06 PM
broulik added inline comments.

KSqueezedTextLabel doesn't help?

sitter added inline comments.Jan 16 2020, 3:46 PM

Never knew this was a thing!
Looks like this would require lots of fiddling though. It seems to bug out with AlignLeft in the grid layout, and also one would have to know what size the qlabel should be I guess.

...the trouble is more that a long label looks silly

, not just that it should fit within the size constraint

davidedmundson accepted this revision.Jan 19 2020, 6:29 PM
This revision is now accepted and ready to land.Jan 19 2020, 6:29 PM
sitter edited the summary of this revision. (Show Details)Jan 23 2020, 9:59 AM

Maybe the label should say "Graphics:" or "Graphics Processor" instead of using an acronym. We say "Memory" instead of "RAM" after all.

Good point.

sitter updated this revision to Diff 74250.Jan 23 2020, 3:39 PM

s/gpu/graphics processor/

ngraham accepted this revision.Jan 23 2020, 3:49 PM
This revision was automatically updated to reflect the committed changes.