add gpu entry to about system
ClosedPublic
Actions

Authored by sitter on Jan 16 2020, 3:06 PM.

Details

Reviewers

davidedmundson
ngraham

Commits

R102:55912f121c61: add gpu entry to about system

Summary

simply queries gl_renderer from gl

also refactor string processing for (R) and (TM) replacement so
it can be shared for cpu and gpu entries

I do wonder if we need to blacklist software gl somehow though

BUG: 355053
FIXED-IN: 5.19.0

Test Plan

shows something of value on amd and intel

depends on D26667

Repository

R102 KInfoCenter

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

sitter requested review of this revision.Jan 16 2020, 3:06 PM

broulik added inline comments.

Modules/about-distro/src/GPUEntry.cpp
50	`KSqueezedTextLabel` doesn't help?

Modules/about-distro/src/GPUEntry.cpp
50	Never knew this was a thing! Looks like this would require lots of fiddling though. It seems to bug out with AlignLeft in the grid layout, and also one would have to know what size the qlabel should be I guess. ...the trouble is more that a long label looks silly , not just that it should fit within the size constraint

This revision is now accepted and ready to land.Jan 19 2020, 6:29 PM

Maybe the label should say "Graphics:" or "Graphics Processor" instead of using an acronym. We say "Memory" instead of "RAM" after all.

Good point.

s/gpu/graphics processor/

This revision was automatically updated to reflect the committed changes.

		Path
M		Modules/about-distro/src/CMakeLists.txt (2 lines)
M		Modules/about-distro/src/CPUEntry.cpp (7 lines)
A	M	Modules/about-distro/src/FancyString.h (17 lines)
A	M	Modules/about-distro/src/FancyString.cpp (19 lines)
A	M	Modules/about-distro/src/GPUEntry.h (18 lines)
A	M	Modules/about-distro/src/GPUEntry.cpp (42 lines)
M		Modules/about-distro/src/Module.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	73710	5fef9b6		Jan 16 2020, 3:06 PM	★	★
Diff 2	74250	5fef9b6	s/gpu/graphics processor/	Jan 23 2020, 3:39 PM	★	★
Diff 3	75036	4b4f6a3	R102:55912f121c618b23ec6dc901b33e3184c2ec9413	Feb 5 2020, 9:48 AM	★	★