refactor about-distro to more generically support textual dumps
Needs ReviewPublic

Authored by sitter on Tue, Jan 14, 3:35 PM.
This revision needs review, but there are no reviewers specified.



this previously relied on manually replicating strings and whatnot, it was
very awkward to read and the load functions were also getting a bit long.

introducing the new entry system:
generic table entries are now represented by a more generic Entry object
comprised of the entry label (e.g. 'Plasma Version:') and its value
(e.g. '5.17.0'). from those entries the UI is then constructed (i.e.
large parts of the UI are now no longer in the designer file but rather
constructed manually).
all visible entries are further more collected in a global list of entries
from which we'll generate the clipboard dump.
localization switching is now carried out through KLocalized String instead
of having string copies floating about. depending on context we'll either
resolve the localized or original string.

this should also make it easier to change the data set in the future, be
it adding or removing new data

RTL languages have a broken clipboard but it looks that was the case before
as well and I utterly failed to bend it into shape with bidirectional
control characters :(

Test Plan
  1. LANGUAGE=en
  2. all entires shown
  3. copy to clipboard dumps all entries as before
  1. LANGUAGE=de
  2. as above
  3. copy to as english dumps in english rather than german
  1. LANGUAGE=he
  2. as above
  3. copy in hebrew seems incorrectly order (probably because bidi algorithm falls over from both the RTL label being in the same line as the LTR numbers)

Diff Detail

R102 KInfoCenter
No Linters Available
No Unit Test Coverage
Build Status
Buildable 21234
Build 21252: arc lint + arc unit
sitter created this revision.Tue, Jan 14, 3:35 PM
Restricted Application added a project: Plasma. · View Herald TranscriptTue, Jan 14, 3:35 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Tue, Jan 14, 3:35 PM

not sure if it's worth splitting into multiple files. personally I prefer many tiny files over one long one though *shrug*.

sitter updated this revision to Diff 73602.Wed, Jan 15, 9:27 AM

forgot to actually write cleanup after having wanted to twice :'D

sitter updated this revision to Diff 73707.Thu, Jan 16, 2:42 PM

split into one class per file

sitter updated this revision to Diff 73708.Thu, Jan 16, 2:48 PM

remove extra file