downloadNewWhat: i18n("Wallpapers")

But now the translation does not work.
This is reported here https://bugs.kde.org/show_bug.cgi?id=415541
Now I am fixing this error with three patches.

What about the "Get New Plugins" button in the same dialog? It still uses the old style.
Probably unrelated, but for me, both of these buttons fail to actually load anything, stuck connecting forever. I would blame all of my internet connections that I tried it with, but it does not happen in System Settings, so maybe there's some bug here.

And also, looking at @victorr's screenshot, I see that the "Close" button has no label on it. I got same problem here as well.

In D26665#601713, @IlyaBizyaev wrote:

What about the "Get New Plugins" button in the same dialog? It still uses the old style.
Probably unrelated, but for me, both of these buttons fail to actually load anything, stuck connecting forever. I would blame all of my internet connections that I tried it with, but it does not happen in System Settings, so maybe there's some bug here.

The reason that wasn't changed in this step is simple - because it isn't simple ;) You'll notice that the change here was very much a trivial swap. Changing the other KNS integration points out for the new one will be considerably more effort, hence it isn't happening just yet.

And also, looking at @victorr's screenshot, I see that the "Close" button has no label on it. I got same problem here as well.

That really is a very strange error. Not sure why such a thing would fail. The code in question can be seen here: https://phabricator.kde.org/source/knewstuff/browse/master/src/qtquick/qml/Dialog.qml$98 - However, the whole thing is also being discussed elsewhere, making this the wrong place. Would be good to get more eyes on the situation :) https://bugs.kde.org/show_bug.cgi?id=413434

In D26665#601715, @leinir wrote:

In D26665#601713, @IlyaBizyaev wrote:

What about the "Get New Plugins" button in the same dialog? It still uses the old style.

The reason that wasn't changed in this step is simple - because it isn't simple ;) You'll notice that the change here was very much a trivial swap. Changing the other KNS integration points out for the new one will be considerably more effort, hence it isn't happening just yet.

But now we have three different user interfaces for getting KNS content: 1. Discover 2. old dialog 3. new dialog. This is really kind of non-ideal. I was hoping we could swap out all the old dialogs for the new ones throughout System Settings and Plasma for 5.18. In the long term, I'd like to have one interface for all GHNS stuff, whether it be the new dialog or Discover, or something else. But three is now a regression in our quest for Goal: Consistency. :/

In D26665#601715, @leinir wrote:

In D26665#601713, @IlyaBizyaev wrote:

And also, looking at @victorr's screenshot, I see that the "Close" button has no label on it. I got same problem here as well.

That really is a very strange error. Not sure why such a thing would fail. The code in question can be seen here: https://phabricator.kde.org/source/knewstuff/browse/master/src/qtquick/qml/Dialog.qml$98 - However, the whole thing is also being discussed elsewhere, making this the wrong place. Would be good to get more eyes on the situation :) https://bugs.kde.org/show_bug.cgi?id=413434

Just delete it :)