Use more conventional "Add to Places" text for that action
ClosedPublic

Authored by ngraham on Sat, Jan 11, 8:08 PM.

Details

Summary

I originally implemented this to show "Add <current folder> to Places" to make the menu
item more clear when invoked from the file menu or the viewport context menu because I
thought it wasn't totally clear that the action would be referring to the folder for the
visible view.

However I think in retrospect that this was a mistake. No other items in the file menu
or the viewport context menu name the current folder like this, so clearly there wasn't
a problem. And then the item's text doesn't match the text for other items.

Thie patch removes that behavior and makes the name match the style of all the other menu
item text.

BUG: 416064
FIXED-IN: 20.04.0

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Sat, Jan 11, 8:08 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptSat, Jan 11, 8:08 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
ngraham requested review of this revision.Sat, Jan 11, 8:08 PM
ngraham updated this revision to Diff 73298.Sat, Jan 11, 8:09 PM

Fix one thing I missed (isn't it weird how you sometimes only notice an issue with your patch right after you've submitted it?)

meven requested changes to this revision.Sun, Jan 12, 11:22 AM
meven added a subscriber: meven.

I would delete those setText here and add it when the action is created around line 1328, since the text does not change anymore.

This revision now requires changes to proceed.Sun, Jan 12, 11:22 AM

I would delete those setText here and add it when the action is created around line 1328, since the text does not change anymore.

+1

ngraham updated this revision to Diff 73362.Mon, Jan 13, 3:11 AM

Set text only once in the correct place

meven accepted this revision.Mon, Jan 13, 7:55 AM
This revision is now accepted and ready to land.Mon, Jan 13, 7:55 AM
This revision was automatically updated to reflect the committed changes.